On Wed, Apr 23, 2025 at 03:29:03PM -0600, Uday Shankar wrote: > Some distributions, such as centos stream 9, still have a version of > coreutils which does not yet support the %Hr and %Lr formats for stat(1) > [1, 2]. Running ublk selftests on these distributions results in the > following error in tests that use the _get_disk_dev_t helper: > > line 23: ?r: syntax error: operand expected (error token is "?r") > > To better accommodate older distributions, rewrite _get_disk_dev_t to > use the much older %t and %T formats for stat instead. > > [1] https://github.com/coreutils/coreutils/blob/v9.0/NEWS#L114 > [2] https://pkgs.org/download/coreutils > > Signed-off-by: Uday Shankar <ushankar@xxxxxxxxxxxxxxx> > --- > tools/testing/selftests/ublk/test_common.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/ublk/test_common.sh b/tools/testing/selftests/ublk/test_common.sh > index 9fc111f64576f91adb731d436c2d535f7dfe5c2e..a81210ca3e99d264f84260aab35827e0c00add01 100755 > --- a/tools/testing/selftests/ublk/test_common.sh > +++ b/tools/testing/selftests/ublk/test_common.sh > @@ -17,8 +17,8 @@ _get_disk_dev_t() { > local minor > > dev=/dev/ublkb"${dev_id}" > - major=$(stat -c '%Hr' "$dev") > - minor=$(stat -c '%Lr' "$dev") > + major="0x"$(stat -c '%t' "$dev") > + minor="0x"$(stat -c '%T' "$dev") Reviewed-by: Ming Lei <ming.lei@xxxxxxxxxx> Thanks, Ming
