Re: Block device's sysfs setting getting lost after suspend-resume cycle

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2025-04-23 18:19, Christoph Hellwig wrote:
So I tried to figure out how this happened, but AFAIK even
the pre atomic limits code (blk_queue_io_opt) always overrode
ra_pages.  So for nvme in particular this either was introduced by

81adb863349157c67ccec871e5ae5574600c50be (HEAD)
Author: Bart Van Assche <bvanassche@xxxxxxx>
Date:   Fri Jun 28 09:53:31 2019 -0700

     nvme: set physical block size and optimal I/O size

which is so old that my current compiler refuses to build that
kernel to verify it, or by the fact that you either upgraded your SSD
or the SSD firmware to set the relevant limit which was added to
nvme only a little before that.

No good fixes tag I guess, but I'll formally send out the patch anyway.

There may have been a misunderstanding. I first noticed this on an old
machine with SATA SSDs where I *do* have an udev rule for readahead.
I only used my laptop with NVME drive (from ~2021) to reproduce the problem
and send the email. On that machine I do not have any udev rule to set
readahead since it's plenty fast.

Not sure if that matters, as it was a valid bug after all and now
it's fixed, so thanks again!

cheers
Holger




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux