On Tue, Apr 22, 2025 at 04:36:08PM +0800, Ming Lei wrote: > Please see the following patch of 'block: move elv_register[unregister]_queue out of elevator_lock' > in which elevator_change_done() has to be added, then the context structure > can't be kept as private any more. It can. See the attached first patch. The second patch then cleans things up further so that we don't need the force flag or __elevator_change. > > > > Also please use a flags value with named flags instead of the various > > booleans. > > 'struct elv_change_ctx' has to be parameter, so it doesn't matter to > use flags value any more, and 'bool' should be easier. It's still much more readable to have flags. Especially to discover and document how init and uevent are related, which seems rather confusing at the moment.
