On Tue, Apr 22, 2025 at 07:59:41AM +0800, Ming Lei wrote:
> When adding recovery test:
>
> - 'break' is missed for handling '-g' argument
>
> - test name of test_generic_05.sh is wrong
>
> So fix the two.
>
> Fixes: 57e13a2e8cd2 ("selftests: ublk: support user recovery")
> Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxx>
Reviewed-by: Uday Shankar <ushankar@xxxxxxxxxxxxxxx>
> ---
> tools/testing/selftests/ublk/kublk.c | 1 +
> tools/testing/selftests/ublk/test_generic_05.sh | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/ublk/kublk.c b/tools/testing/selftests/ublk/kublk.c
> index 759f06637146..e57a1486bb48 100644
> --- a/tools/testing/selftests/ublk/kublk.c
> +++ b/tools/testing/selftests/ublk/kublk.c
> @@ -1354,6 +1354,7 @@ int main(int argc, char *argv[])
> value = strtol(optarg, NULL, 10);
> if (value)
> ctx.flags |= UBLK_F_NEED_GET_DATA;
> + break;
> case 0:
> if (!strcmp(longopts[option_idx].name, "debug_mask"))
> ublk_dbg_mask = strtol(optarg, NULL, 16);
> diff --git a/tools/testing/selftests/ublk/test_generic_05.sh b/tools/testing/selftests/ublk/test_generic_05.sh
> index 714630b4b329..3bb00a347402 100755
> --- a/tools/testing/selftests/ublk/test_generic_05.sh
> +++ b/tools/testing/selftests/ublk/test_generic_05.sh
> @@ -3,7 +3,7 @@
>
> . "$(cd "$(dirname "$0")" && pwd)"/test_common.sh
>
> -TID="generic_04"
> +TID="generic_05"
> ERR_CODE=0
>
> ublk_run_recover_test()
> --
> 2.47.0
>
