Re: [PATCH V3 4/7] blk-throttle: Introduce flag "BIO_TG_BPS_THROTTLED"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





在 2025/4/21 20:03, Christoph Hellwig 写道:
On Fri, Apr 18, 2025 at 12:09:21PM +0800, Zizhi Wo wrote:
+	/*
+	 * This bio has undergone rate limiting at the single throtl_grp level bps
+	 * queue. Since throttle and QoS are not at the same level, reuse the value.
+	 */

Please limit your comments to 80 characters to keep them readable.

Sorry, I didn't notice that earlier — I'll make sure to stick to the
80-character limit.


But I also don't understand what "level" even means here.


The first "level" refers to the granularity of the tg; this flag needs
to be cleared when bio moving up to the upper-level tg, for example:
tg_dispatch_one_bio->throtl_add_bio_tg.

The second "level" refers to the fact that throttle and rq_qos are not
on the same layer, so reuse this flag.

Thanks,
Zizhi Wo






[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux