On Fri, Apr 18, 2025 at 05:38:25PM +0800, Yu Kuai wrote: > + sector_t aligned_end = round_down(sector + (size >> SECTOR_SHIFT), > + PAGE_SECTORS); Nit: I think the version below would be a bit more readable: sector_t aligned_end = round_down(sector + (size >> SECTOR_SHIFT), PAGE_SECTORS); otherwise look good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>