On Wed, Apr 16, 2025 at 10:06:13AM -0600, Caleb Sander Mateos wrote: > sg_next() is a short function called frequently in I/O paths. Define it > in the header file so it can be inlined into its callers. > > Signed-off-by: Caleb Sander Mateos <csander@xxxxxxxxxxxxxxx> Reviewed-by: Eric Biggers <ebiggers@xxxxxxxxxx> I had been thinking about doing this too. Besides the benefits for storage, this will also reduce the overhead in some parts of the crypto subsystem. > Is it a concern that this would break kernel modules built against old headers? > If so, I could update the patch to continue compiling and exporting sg_next() in > scatterlist.c. No, that's not a concern. - Eric
