On Mon, Apr 14, 2025 at 08:09:59AM +0200, Christoph Hellwig wrote: > On Mon, Apr 14, 2025 at 08:58:28AM +0800, Ming Lei wrote: > > > Coming back to this after looking through the next patches. > > > > > > Why do we even need the __elevator_change call here? We've not > > > actually disabled the elevator, and we prevent other callers > > > from changing it. > > > > > > As you pass in the force argument this now always calls > > > elevator_switch and thus blk_mq_init_sched. But why? > > > > sched tags is built over hctx and depends on ->nr_hw_queues, > > when nr_hw_queues is changed, sched tags has to be rebuilt. > > Can you add a comment explaining this? Sure. Thanks, Ming
