Re: [PATCH 03/15] block: move sched debugfs register into elvevator_register_queue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 10, 2025 at 04:27:20PM +0200, Christoph Hellwig wrote:
> >  	lockdep_assert_held(&q->elevator_lock);
> >  
> > +	if (test_bit(ELEVATOR_FLAG_REGISTERED, &e->flags))
> > +		return 0;
> > +
> 
> This looks unrelate to the rest of the patch, and I also don't understand
> why it's needed as the callers of elv_register_queue don't change.

The check is actually missed, I will move it into one single patch.

Thanks,
Ming





[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux