On Fri, Apr 04, 2025 at 08:03:33AM +0000, Shinichiro Kawasaki wrote:
> On Mar 18, 2025 / 11:38, Daniel Wagner wrote:
> > Signed-off-by: Daniel Wagner <wagi@xxxxxxxxxx>
> > ---
> > common/nvme | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/common/nvme b/common/nvme
> > index 3761329d39e3763136f60a4751ad15de347f6e9b..a3176ecff2e5fbc0fbe09460c21e9f50c68d3bce 100644
> > --- a/common/nvme
> > +++ b/common/nvme
> > @@ -26,6 +26,7 @@ nvmet_blkdev_type=${nvmet_blkdev_type:-"device"}
> > NVMET_BLKDEV_TYPES=${NVMET_BLKDEV_TYPES:-"device file"}
> > nvme_target_control="${NVME_TARGET_CONTROL:-}"
> > NVMET_CFS="/sys/kernel/config/nvmet/"
> > +NVMET_DFS="/sys/kernel/debug/nvmet/"
>
> This causes the shellcheck warning SC2034.
>
> common/nvme:29:1: warning: NVMET_DFS appears unused. Verify use (or export if used externally). [SC2034]
>
> I suggest to annotate "# shellcheck disable=SC2034" above the added line.
Will do. I keep forgetting to run shellcheck, sorry about that.
