On Mar 07, 2025 / 16:03, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@xxxxxxxxxx>
>
> Add test for IO merge over iops limit.
>
> Noted this test will fail for now, kernel solution is in development.
Thanks Yu. I will add nit comments below. I will do review again and trial runs
when the kernel solution gets available.
>
> Signed-off-by: Yu Kuai <yukuai3@xxxxxxxxxx>
> ---
> tests/throtl/007 | 65 ++++++++++++++++++++++++++++++++++++++++++++
> tests/throtl/007.out | 4 +++
> 2 files changed, 69 insertions(+)
> create mode 100755 tests/throtl/007
> create mode 100644 tests/throtl/007.out
>
> diff --git a/tests/throtl/007 b/tests/throtl/007
> new file mode 100755
> index 0000000..597f879
> --- /dev/null
> +++ b/tests/throtl/007
> @@ -0,0 +1,65 @@
> +#!/bin/bash
> +# SPDX-License-Identifier: GPL-3.0+
> +# Copyright (C) 2025 Yu Kuai
> +#
> +# Test iops limit over io merge
> +
> +. tests/throtl/rc
> +
> +DESCRIPTION="basic functionality"
I expect this will be updated
> +QUICK=1
> +
> +requires() {
> + _have_program taskset
This line is not necessary. taskset is included in util-linux, which the "check"
script confirms avialability.
> + _have_program fio
I recommend _have_fio instead.
> +}
> +
> +# every 16 0.5k IO will merge into one 8k IO, ideally runtime is 1s,
> +# however it's about 1.3s in practice
> +__fio() {
I guess you will think about better name of this function here. "run_fio" or
something? It's the better to not have underscore prefix.
