On 31/08/2025 23:28, Sebastian Reichel wrote: > Add binding for the EC found in the Thinkpad T14s Gen6 Snapdragon, > which is based on the Qualcomm X1 Elite. Some of the system LEDs > and extra keys are only accessible via the EC. > > Signed-off-by: Sebastian Reichel <sre@xxxxxxxxxx> > --- > .../bindings/platform/lenovo,thinkpad-t14s-ec.yaml | 49 ++++++++++++++++++++++ Please place it in embedded-controller. I moved there all ECs. > 1 file changed, 49 insertions(+) > > diff --git a/Documentation/devicetree/bindings/platform/lenovo,thinkpad-t14s-ec.yaml b/Documentation/devicetree/bindings/platform/lenovo,thinkpad-t14s-ec.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..bab20df2d9ede9a3cb0359944b26b3d18ff7d9b8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/platform/lenovo,thinkpad-t14s-ec.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/platform/lenovo,thinkpad-t14s-ec.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Lenovo Thinkpad T14s Embedded Controller. Drop full stop, titles never have them. > + > +maintainers: > + - Sebastian Reichel <sre@xxxxxxxxxx> > + > +description: > + The Qualcomm Snapdragon-based Lenovo Thinkpad T14s has an Embedded Controller > + (EC) which handles things such as keyboard backlight, LEDs or non-standard keys. Please wrap at 80. > + This binding describes the interface, on an I2C bus, to this EC. Drop, or just describe the hardware, not binding. > + > +properties: > + compatible: > + const: lenovo,thinkpad-t14s-ec > + > + reg: > + const: 0x28 > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - |+ > + #include <dt-bindings/interrupt-controller/irq.h> > + i2c1 { i2c > + clock-frequency = <400000>; Drop > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + embedded-controller@28 { > + compatible = "lenovo,thinkpad-t14s-ec"; > + reg = <0x28>; > + interrupts-extended = <&tlmm 66 IRQ_TYPE_LEVEL_LOW>; > + }; > + }; > +... > Best regards, Krzysztof
