On 2025-09-01 18:01, Bjorn Andersson wrote:
On Sat, Aug 30, 2025 at 11:59:30PM +0200, Barnabás Czémán wrote:
Correct cd-gpios in xiaomi-daisy according to downstream sources
it is using GPIO_ACTIVE_HIGH instead of GPIO_ACTIVE_LOW.
Is the problem you're solving that the DT doesn't match downstream, or
that card detect doesn't work? Does it work after this patch, or is it
just aligned with downstream?
Regards,
Bjorn
Both, it was not matching with downstream and card detect was not
working.
It is working with this patch.
Fixes: 38d779c26395 ("arm64: dts: qcom: msm8953: Add device tree for
Xiaomi Mi A2 Lite")
Signed-off-by: Barnabás Czémán <barnabas.czeman@xxxxxxxxxxxxxx>
---
arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
b/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
index
336b916729e4721b5ba8f4f7e368d0d838aa54ab..ddd7af616794290aa1f06228a95cfa1d42b006e6
100644
--- a/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
+++ b/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
@@ -296,7 +296,7 @@ &sdhc_2 {
vmmc-supply = <&pm8953_l11>;
vqmmc-supply = <&pm8953_l12>;
- cd-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>;
+ cd-gpios = <&tlmm 133 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default", "sleep";
pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_on>;
---
base-commit: 3cace99d63192a7250461b058279a42d91075d0c
change-id: 20250830-daisy-sd-fix-011c23468e2a
Best regards,
--
Barnabás Czémán <barnabas.czeman@xxxxxxxxxxxxxx>
