On 8/16/2025 4:51 PM, Bryan O'Donoghue wrote:
> On 13/08/2025 10:38, Dikshita Agarwal wrote:
>> + if (type == DECODER) {
>> + strscpy(vdev->name, "qcom-iris-decoder", sizeof(vdev->name));
>> + ret = video_register_device(vdev, VFL_TYPE_VIDEO, -1);
>> + if (ret)
>> + goto err_vdev_release;
>> + core->vdev_dec = vdev;
>> + } else if (type == ENCODER) {
>> + strscpy(vdev->name, "qcom-iris-encoder", sizeof(vdev->name));
>> + ret = video_register_device(vdev, VFL_TYPE_VIDEO, -1);
>> + if (ret)
>> + goto err_vdev_release;
>> + core->vdev_enc = vdev;
>> + } else {
>
> A bit of duplicate reduction.
>
> if (type == DECODER) {
> strscpy(vdev->name, "qcom-iris-decoder", sizeof(vdev->name));
> core->vdev_dec = vdev;
> } else if (type == ENCODER) {
> strscpy(vdev->name, "qcom-iris-encoder", sizeof(vdev->name));
> core->vdev_enc = vdev;
> } else {
> ret = -EINVAL;
> goto err_vdev_release;
> }
>
> ret = video_register_device(vdev, VFL_TYPE_VIDEO, -1);
> if (ret)
> goto err_vdev_release;
>
> once done
Sure, will fix.
>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
>
> ---
> bod
