On 8/18/2025 12:59 PM, Dikshita Agarwal wrote: >>> diff --git a/drivers/media/platform/qcom/iris/iris_venc.c b/drivers/media/platform/qcom/iris/iris_venc.c >>> index 930f5afe9489d01be193f1dbe429d33f5401b468..11666f40a4d1c34e1b6eca0b5e40e0f09eeb2b67 100644 >>> --- a/drivers/media/platform/qcom/iris/iris_venc.c >>> +++ b/drivers/media/platform/qcom/iris/iris_venc.c >>> @@ -58,6 +58,9 @@ int iris_venc_inst_init(struct iris_inst *inst) >>> inst->crop.width = f->fmt.pix_mp.width; >>> inst->crop.height = f->fmt.pix_mp.height; >>> >>> + inst->operating_rate = DEFAULT_FPS << 16; >>> + inst->frame_rate = DEFAULT_FPS << 16; >> I understand that firmware expects the rate in Q16 format, but does driver needs >> to keep it in that format ? I see most of the time in calculations, it is right >> shifted to bring it back to normal one and then back n forth. >> > Currently in driver inst->frame_rate is in Q16 format everywhere, no > inconsistency. > > do you prefer to keep it in non Q16 format and convert to Q16 when setting > to firmware? > Given that it simplifies the handling in driver, by avoiding doing the adjustment everytime before using that value, yes please. Regards, Vikash
