Re: [PATCH] media: iris: Fix firmware reference leak and unmap memory after load

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Stephan Gerhold <stephan.gerhold@xxxxxxxxxx>
Subject: Re: [PATCH] media: iris: Fix firmware reference leak and unmap memory after load
From: "Bryan O'Donoghue" <bryan.odonoghue@xxxxxxxxxx>
Date: Mon, 18 Aug 2025 12:01:42 +0100
Cc: Vikash Garodia <quic_vgarodia@xxxxxxxxxxx>, Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx>, Abhinav Kumar <abhinav.kumar@xxxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>, Stefan Schmidt <stefan.schmidt@xxxxxxxxxx>, Hans Verkuil <hverkuil@xxxxxxxxxx>, linux-media@xxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Neil Armstrong <neil.armstrong@xxxxxxxxxx>
In-reply-to: <20250818-iris-firmware-leak-v1-1-1e3f9b8d31ce@linaro.org>
References: <20250818-iris-firmware-leak-v1-1-1e3f9b8d31ce@linaro.org>
User-agent: Mozilla Thunderbird

On 18/08/2025 10:50, Stephan Gerhold wrote:

+	ret = qcom_scm_pas_auth_and_reset(core->iris_platform_data->pas_id);


You're not using the latched pas_id declared @ the top of this function.

With that fixed.

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>

Follow-Ups:
- Re: [PATCH] media: iris: Fix firmware reference leak and unmap memory after load
  - From: Bryan O'Donoghue

References:
- [PATCH] media: iris: Fix firmware reference leak and unmap memory after load
  - From: Stephan Gerhold

Prev by Date: Converting logging dev_* functions to drm_*
Next by Date: Re: [PATCH v2 04/24] media: iris: Fix port streaming handling
Previous by thread: Re: [PATCH] media: iris: Fix firmware reference leak and unmap memory after load
Next by thread: Re: [PATCH] media: iris: Fix firmware reference leak and unmap memory after load
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [Linux for Sparc] [IETF Annouce] [Security] [Bugtraq] [Linux MIPS] [ECOS] [Asterisk Internet PBX] [Linux API]