On 8/20/2025 7:09 PM, Stephan Gerhold wrote:
>>>> +int iris_fw_init(struct iris_core *core)
>>>> +{
>>>> + struct platform_device_info info;
>>>> + struct iommu_domain *iommu_dom;
>>>> + struct platform_device *pdev;
>>>> + struct device_node *np;
>>>> + int ret;
>>>> +
>>>> + np = of_get_child_by_name(core->dev->of_node, "video-firmware");
>>>> + if (!np)
>>>> + return 0;
>>> You need a dt-bindings change for this as well. This is documented only
>>> for Venus.
>> You are right, wanted to send device tree and binding support separately.
>> But if required, will add with the series in the next version.
>>
> You can send device tree changes separately, but dt-binding changes
> always need to come before the driver changes.
Do you mean to update the examples section[1] with the firmware subnode,
something similar to venus schema[2] ?
Regards,
Vikash
[1]
https://elixir.bootlin.com/linux/v6.17-rc2/source/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml#L109
[2]
https://elixir.bootlin.com/linux/v6.17-rc2/source/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml#L128
