On 15-08-25, 06:32, Srinivas Kandagatla wrote: > Hi Vinod, > On 7/4/25 1:12 PM, srinivas.kandagatla@xxxxxxxxxxxxxxxx wrote: > > From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxxxxxxxx> > > > > All these 3 codecs have been duplicating two of the soundwire > > functions. Noticed another new driver starting to do the same, its time > > to make some helpers so that we do not duplicate these functions. > > > > I have added two helpers of_sdw_find_device_by_node() and > > sdw_slave_get_current_bank() in soundwire layer for the codecs to use them. > > > > Changes since v1: > > - updated sdw_slave_get_current_bank do error checks on read > > > > Srinivas Kandagatla (4): > > soundwire: bus: add of_sdw_find_device_by_node helper > > soundwire: bus: add sdw_slave_get_current_bank helper > > > Do you have any comments these two soundwire patches in this series? Yes I am nota helpers like this, but I dont think it is big deal so: Acked-by: Vinod Koul <vkoul@xxxxxxxxxx> -- ~Vinod
