On Sat, Aug 23, 2025 at 6:50 AM Dmitry Baryshkov
<dmitry.baryshkov@xxxxxxxxxxxxxxxx> wrote:
>
> On Fri, Aug 22, 2025 at 05:14:02PM -0700, Rob Clark wrote:
> > On Fri, Aug 22, 2025 at 5:12 PM Dmitry Baryshkov
> > <dmitry.baryshkov@xxxxxxxxxxxxxxxx> wrote:
> > >
> > > Since commit 3309323241fb ("drm/gpuvm: Kill drm_gpuva_init()") MSM
> > > driver fails to init, failing with "[drm:msm_gpu_init] *ERROR* could not
> > > allocate memptrs: -22" errors. The mentioned commit reworked the
> > > function, but didn't take into account that op_map is initialized at the
> > > top of the function, while ranges might change if GPUVM is managed by
> > > the kernel.
> > >
> > > Move op_mode initialization after finalizing all addresses and right
> > > before the drm_gpuva_init_from_op() call.
> > >
> > > Reported-by: Danct12 <danct12@xxxxxxxxxxx>
> > > Fixes: 3309323241fb ("drm/gpuvm: Kill drm_gpuva_init()")
> > > Suggested-by: Rob Clark <robin.clark@xxxxxxxxxxxxxxxx>
> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> > > ---
> > > drivers/gpu/drm/msm/msm_gem_vma.c | 13 +++++++------
> > > 1 file changed, 7 insertions(+), 6 deletions(-)
> > >
> >
> > Thanks,
> >
> > Reviewed-by: Rob Clark <rob.clark@xxxxxxxxxxxxxxxx>
>
> I'll also need Acked-by to merge through drm-misc-next, where the
> offending commit is.
>
Acked-by: Rob Clark <rob.clark@xxxxxxxxxxxxxxxx>
>
> --
> With best wishes
> Dmitry
