On 8/22/2025 4:59 PM, Neil Armstrong wrote: > On 20/08/2025 11:07, Dikshita Agarwal wrote: >> Hi All, >> >> This patch series adds support for H.264 and H.265 encoder in iris >> driver and includes a few fixes and cleanup in the common code that were >> identified during encoder bring-up process. >> >> The changes include: >> - Enabling support for H.264 and H.265 encoding. >> - Fixes and improvements in shared componenets used by both encoder and >> decoder paths. >> - Ensuring compatibility and stability with the existing decoder flow. >> >> Changes in v3: >> - Fixed the log when destroying the interanl buffers (Jorge) >> - Updated commit text with issue details in patch 05/25 (Krzysztof) >> - Added a patch to simplify conditional logic in stop handling for hfi gen1 >> (Bryan) >> - Reduced duplicate code while registering video devices (Bryan) >> - Added a fix for try fmt handling in decoder (Self) >> - Fixed the value of max core mbps for qcs8300 (Vikash) >> - Simplied the frame rate handling in driver by using non q16 format and >> converted to q16 when setting to firmware (Vikash) >> - Fixed the issue with bitstream resolution setting to firmware (Neil) >> - Addressed other review comments (Vikash, Bryan) >> - Link to v2: >> https://lore.kernel.org/r/20250813-iris-video-encoder-v2-0-c725ff673078@xxxxxxxxxxx >> >> Changes in v2: >> - Fixed sparse/coccinnelle issues. >> - Fixed the kernel doc warning. >> - Removed unsupported PEAK_BITRATE property from SM8250. >> - Dropped patch 04/25 to fix quality issue with encoder. >> - Enhanced command handling for encoder to allow start/stop commands. >> - Expanded rate control condition checks to include additional rate >> control types for HFI Gen2. >> - Updated default value to MAX_QP for all caps related to max QP settings. >> - Add support for INPUT/OUTPUT_BUF_HOST_MAX_COUNT caps for encoder. >> - Link to v1: >> https://lore.kernel.org/r/20250704-iris-video-encoder-v1-0-b6ce24e273cf@xxxxxxxxxxx >> >> All patches have been tested with v4l2-compliance, v4l2-ctl and >> Gstreamer on SM8250 and SM8550 for encoder, at the same time ensured >> that the existing decoder functionality remains uneffected. >> >> Commands used for V4l2-ctl validation: >> >> v4l2-ctl --verbose --set-fmt-video-out=width=1280,height=720,pixelformat=NV12 >> --set-selection-output target=crop,top=0,left=0,width=1280,height=720 >> --set-fmt-video=pixelformat=H264 --stream-mmap --stream-out-mmap >> --stream-from=/media/cyclists_1280x720_92frames.yuv >> --stream-to=/tmp/cyclists_1280x720_92frames.h264 -d /dev/video1 >> >> v4l2-ctl --verbose --set-fmt-video-out=width=1280,height=720,pixelformat=NV12 >> --set-selection-output target=crop,top=0,left=0,width=1280,height=720 >> --set-fmt-video=pixelformat=HEVC --stream-mmap --stream-out-mmap >> --stream-from=/media/cyclists_1280x720_92frames.yuv >> --stream-to=/tmp/cyclists_1280x720_92frames.hevc -d /dev/video1 >> >> Commands used for GST validation: >> >> gst-launch-1.0 -v filesrc location=/media/cyclists_1280x720_92frames.yuv ! >> rawvideoparse format=nv12 width=1280 height=720 framerate=30/1 ! v4l2h264enc >> capture-io-mode=4 output-io-mode=4 ! filesink sync=true >> location=/tmp/gst_cyclists_1280x720_92frames.h264 >> >> gst-launch-1.0 -v filesrc location=/media/cyclists_1280x720_92frames.yuv ! >> rawvideoparse format=nv12 width=1280 height=720 framerate=30/1 ! v4l2h265enc >> capture-io-mode=4 output-io-mode=4 ! filesink sync=true >> location=/tmp/gst_cyclists_1280x720_92frames.hevc <snip> > > Thanks ! > > Tested-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> # on SM8550-HDK > Tested-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> # on SM8650-HDK > > It still requires some sm8650 specific buffer calculations tweaks > to support new firmwares and HEVC for encoding, but I'll post that in > a second time. The core is functional for H264 on older firmwares. > > Neil @Bryan, except the minor fix in #24 (v4 would be needed for it), i do not see any open comments in this series and looks good to me to be pulled once v4 is posted with the fix. Regards, Vikash
