On 28/08/2025 21:23, Nickolay Goppen via B4 Relay wrote: > From: Nickolay Goppen <setotau@xxxxxxxxx> > > Add bindings for pin controller in SDM660 Low Power Audio SubSystem > LPASS). > > Co-developed-by: Richard Acayan <mailingradian@xxxxxxxxx> > Signed-off-by: Richard Acayan <mailingradian@xxxxxxxxx> > Signed-off-by: Nickolay Goppen <setotau@xxxxxxxxx> Completely reversed/messed chain. ... > + > +properties: > + compatible: > + const: qcom,sdm660-lpass-lpi-pinctrl > + > + reg: > + items: > + - description: LPASS LPI TLMM Control and Status registers Clocks missing, maybe some other properties as well. > + > +patternProperties: > + "-state$": > + oneOf: > + - $ref: "#/$defs/qcom-sdm660-lpass-state" > + - patternProperties: > + "-pins$": > + $ref: "#/$defs/qcom-sdm660-lpass-state" > + additionalProperties: false > + > +$defs: > + qcom-sdm660-lpass-state: > + type: object > + description: > + Pinctrl node's client devices use subnodes for desired pin configuration. > + Client device subnodes use below standard properties. > + $ref: qcom,lpass-lpi-common.yaml#/$defs/qcom-tlmm-state > + unevaluatedProperties: false > + > + properties: > + pins: > + description: > + List of gpio pins affected by the properties specified in this > + subnode. > + items: > + pattern: "^gpio([0-9]|[1-2][0-9]|3[0-1])$" > + > + function: > + enum: [ gpio, comp_rx, dmic12, dmic34, mclk0, pdm_2_gpios, > + pdm_clk, pdm_rx, pdm_sync ] > + description: > + Specify the alternative function to be configured for the specified > + pins. > + > +allOf: > + - $ref: qcom,lpass-lpi-common.yaml# > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + lpi_tlmm: pinctrl@15070000 { > + compatible = "qcom,sdm660-lpass-lpi-pinctrl"; > + reg = <0x15070000 0x20000>; > + gpio-controller; > + #gpio-cells = <2>; > + gpio-ranges = <&lpi_tlmm 0 0 32>; That's quite incomplete example. Missing at least one pinmux node. See other files. > + }; > Best regards, Krzysztof