On 9/2/25 11:01 AM, Konrad Dybcio wrote:
> On 9/1/25 9:50 PM, Srinivas Kandagatla wrote:
>> remove read fifo depth field parsing logic, as rd_fifo_depth is never
>> used in the driver, cleaning this up would benefit when adding new
>> version support.
>
> The last sentence is mildly confusing>
Will update this.
--srini
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxxxxxxxx>
>> ---
>> drivers/soundwire/qcom.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
>> index bd2b293b44f2..7f19ebba6137 100644
>> --- a/drivers/soundwire/qcom.c
>> +++ b/drivers/soundwire/qcom.c
>> @@ -209,7 +209,6 @@ struct qcom_swrm_ctrl {
>> int (*reg_write)(struct qcom_swrm_ctrl *ctrl, int reg, int val);
>> u32 slave_status;
>> u32 wr_fifo_depth;
>> - u32 rd_fifo_depth;
>> bool clock_stop_not_supported;
>> };
>>
>> @@ -898,7 +897,7 @@ static int qcom_swrm_init(struct qcom_swrm_ctrl *ctrl)
>> swrm_wait_for_frame_gen_enabled(ctrl);
>> ctrl->slave_status = 0;
>> ctrl->reg_read(ctrl, SWRM_COMP_PARAMS, &val);
>> - ctrl->rd_fifo_depth = FIELD_GET(SWRM_COMP_PARAMS_RD_FIFO_DEPTH, val);
>> +
>
> But my grep confirms this remains unused
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>
> Konrad
