On Tue, Sep 2, 2025 at 3:15 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxx> wrote:
>
> On Tue, Sep 02, 2025 at 01:59:21PM +0200, Bartosz Golaszewski wrote:
> >
> > With the pinmux core no longer duplicating memory used to store the
> > struct pinfunction objects in .rodata, we can now use the existing
> > infrastructure for storing and looking up pin functions in qualcomm
> > drivers. Remove hand-crafted callbacks.
>
> ...
>
> > + for (i = 0; i < soc_data->nfunctions; i++) {
> > + func = &soc_data->functions[i];
> > +
> > + ret = pinmux_generic_add_pinfunction(pctrl->pctrl, func, NULL);
> > + if (ret < 0)
>
> Why not simply
>
> if (ret)
>
> > + return ret;
> > + }
Because it returns a possibly positive selector number.
Bart
