On 03/09/2025 11:31, Konrad Dybcio wrote:
> On 8/21/25 4:16 PM, Krzysztof Kozlowski wrote:
>> Speaker Protection is capability of ADSP to adjust the gain during
>> playback to different speakers and their temperature. This allows good
>> playback without blowing the speakers up.
>
> exciting!
>>
>> Implement parsing MODULE_ID_SPEAKER_PROTECTION from Audioreach topology
>> and sending it as command to the ADSP.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> ---
>
> [...]
>
>> +struct param_id_sp_op_mode {
>> + uint32_t operation_mode;
>
> "u32"
This will be quite inconsistent. See coding style: "you should conform
to the existing choices in that code".
Best regards,
Krzysztof
