On 03/09/2025 15:39, Nickolay Goppen wrote:
> +
> +examples:
> + - |
> + lpi_tlmm: pinctrl@15070000 {
> + compatible = "qcom,sdm660-lpass-lpi-pinctrl";
> + reg = <0x15070000 0x20000>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio-ranges = <&lpi_tlmm 0 0 32>;
> +
> + cdc_pdm_default: cdc-pdm-default-state {
> + clk-pins {
Messed indentation. Keep four spaces.
> + pins = "gpio18";
> + function = "pdm_clk";
> + drive-strength = <8>;
> + output-high;
> + };
> +
> + sync-pins{
> + pins = "gpio19";
> + function = "pdm_sync";
> + drive-strength = <4>;
> + output-high;
> + };
> +
> + tx-pins {
> + pins = "gpio20";
> + function = "pdm_tx";
> + drive-strength = <8>;
> + };
> +
> + rx-pins {
> + pins = "gpio21", "gpio23", "gpio25";
> + function = "pdm_rx";
> + drive-strength = <4>;
> + output-high;
> + };
> + };
> +
> + cdc_comp_default: cdc-comp-default-state {
> + pins = "gpio22", "gpio24";
Also here.
With these fixed:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Best regards,
Krzysztof
