On Thu, Sep 04, 2025 at 11:52:32AM +0200, Krzysztof Kozlowski wrote: > On 03/09/2025 21:33, Hrishabh Rajput via B4 Relay wrote: > > From: Hrishabh Rajput <hrishabh.rajput@xxxxxxxxxxxxxxxx> > > > > The Gunyah Hypervisor applies a devicetree overlay providing the > > pretimeout interrupt for the Gunyah Watchdog that it will be using to > > notify watchdog's pretimeout event. Add the DT bindings that Gunyah > > adheres to for the hypervisor and watchdog. > > Wasn't tested, so limited review. > > Please use subject prefixes matching the subsystem. You can get them for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching. For bindings, the preferred subjects are > explained here: > https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > > A nit, subject: drop second/last, redundant "bindings". The > "dt-bindings" prefix is already stating that these are bindings. > See also: > https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > > > > > > Signed-off-by: Hrishabh Rajput <hrishabh.rajput@xxxxxxxxxxxxxxxx> > > --- > > .../bindings/watchdog/qcom,gh-watchdog.yaml | 76 ++++++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 77 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/watchdog/qcom,gh-watchdog.yaml b/Documentation/devicetree/bindings/watchdog/qcom,gh-watchdog.yaml > > new file mode 100644 > > index 000000000000..bde8438c6242 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/watchdog/qcom,gh-watchdog.yaml > > @@ -0,0 +1,76 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/watchdog/qcom,gh-watchdog.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Qualcomm Gunyah Virtual Watchdog > > + > > +maintainers: > > + - Hrishabh Rajput <hrishabh.rajput@xxxxxxxxxxxxxxxx> > > + > > +description: |+ > > + The Gunyah Hypervisor provides an SMC-based watchdog interface for its virtual > > + machines. The virtual machines use this information to determine the > > + pretimeout IRQ which the hypervisor will be using to communicate pretimeout > > + event. > > + See also: [1] > > + > > + [1]: https://github.com/quic/gunyah-resource-manager/blob/1b23ceb0dfa010b3b6b5a5f7a4ec1e95b93ab99d/src/vm_creation/dto_construct.c#L519 > > + > > +properties: > > + compatible: > > + allOf: > > + - const: gunyah-hypervisor > > + - const: simple-bus > > What? No. > > Don't create patches with AI. > I am next to Hrishabh when he is writing this patch. I can confirm he did not use AI :-) not sure what tool Krzysztof is using to catch patches being written with AI, that tool needs some improvement for sure. I will let Hrishabh share why he put simple-bus here. Thanks, Pavan
