On 9/4/25 1:13 PM, Dmitry Baryshkov wrote: > On Thu, Sep 04, 2025 at 12:47:43PM +0200, Konrad Dybcio wrote: >> On 9/4/25 8:55 AM, Abel Vesa wrote: >>> Add the missing v8 register offsets needed by the eDP/DP PHY driver. >>> >>> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx> >>> --- >> >> + a couple folks that I talked to about this lately >> >> Please create a separate header for this, Glymur contains multiple >> "v8"/"v8.x" PHYs that are not identical to one another (or vs ones >> present on different SoCs), even if advertising that revision > > Is it about v8 vs v8.xx ? No Two (different protocol) PHYs with the same revision data (rev_id register) may have completely different register maps (even in the COM region), both across SoCs and in (at least) Glymur's case, on the same die Two instances of the same PHY (e.g. 2 usb combo PHYs) will not have such differences, just to make it clear Konrad