On Sat, Sep 06, 2025 at 10:26:23PM +0300, Dmitry Baryshkov wrote: > On Sat, Sep 06, 2025 at 12:53:50AM +0530, Umang Chheda wrote: > > From: Mohammad Rafi Shaik <mohammad.rafi.shaik@xxxxxxxxxxxxxxxx> > > > > Add the sound card for monaco-evk board and verified playback > > functionality using the max98357a I2S speaker amplifier and I2S > > microphones. The max98357a speaker amplifier is connected via > > High-Speed MI2S HS0 interface, while the microphones utilize the > > Secondary MI2S interface and also enable required pin controller > > gpios for audio. > > > > Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@xxxxxxxxxxxxxxxx> > > Signed-off-by: Umang Chheda <umang.chheda@xxxxxxxxxxxxxxxx> > > --- > > arch/arm64/boot/dts/qcom/monaco-evk.dts | 52 +++++++++++++++++++++++++ > > arch/arm64/boot/dts/qcom/qcs8300.dtsi | 37 ++++++++++++++++++ > > 2 files changed, 89 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts > > index 93e9e5322a39..f3c5d363921e 100644 > > --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts > > +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts > > @@ -6,6 +6,7 @@ > > /dts-v1/; > > > > #include <dt-bindings/gpio/gpio.h> > > +#include <dt-bindings/sound/qcom,q6afe.h> > > #include <dt-bindings/regulator/qcom,rpmh-regulator.h> > > > > #include "qcs8300.dtsi" > > @@ -24,6 +25,57 @@ aliases { > > chosen { > > stdout-path = "serial0:115200n8"; > > }; > > + > > + dmic: audio-codec-0 { > > + compatible = "dmic-codec"; > > + #sound-dai-cells = <0>; > > + num-channels = <1>; > > + }; > > + > > + max98357a: audio-codec-1 { > > + compatible = "maxim,max98357a"; > > + #sound-dai-cells = <0>; > > + }; > > + > > + sound { > > + compatible = "qcom,qcs8275-sndcard"; > > qcs8300 > If the Monaco EVK actually is QCS8300... But, I presume qcs8275 and qcs8300 are identical when it comes to sound? @Mohammad, if this is the case can't we just support the qcom,monaco-sndcard instead to avoid this confusion? Regards, Bjorn > > + model = "MONACO-EVK"; > > + > > -- > With best wishes > Dmitry