On 14/08/2025 02:59, Harrison Vanderbyl wrote: > Describe describe driver quirks for x1e80100 ufs device > Signed-off-by: Harrison Vanderbyl <harrison.vanderbyl@xxxxxxxxx> > --- > drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 3 +++ > drivers/ufs/host/ufs-qcom.c | 1 + > 2 files changed, 4 insertions(+) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c > index 9c69c77d10c8..b88cafac4da7 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c > @@ -2168,6 +2168,9 @@ static const struct of_device_id qmp_ufs_of_match_table[] = { > }, { > .compatible = "qcom,sm8750-qmp-ufs-phy", > .data = &sm8750_ufsphy_cfg, > + }, { > + .compatible = "qcom,x1e80100-qmp-ufs-phy", > + .data = &sm8550_ufsphy_cfg, So it is fully compatible? If so then don't duplicate entries and express compatibility with fallback. > }, > > { }, > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > index 76fc70503a62..2e143ccd1a03 100644 > --- a/drivers/ufs/host/ufs-qcom.c > +++ b/drivers/ufs/host/ufs-qcom.c > @@ -2282,6 +2282,7 @@ static const struct of_device_id ufs_qcom_of_match[] __maybe_unused = { > { .compatible = "qcom,ufshc" }, > { .compatible = "qcom,sm8550-ufshc", .data = &ufs_qcom_sm8550_drvdata }, > { .compatible = "qcom,sm8650-ufshc", .data = &ufs_qcom_sm8550_drvdata }, > + { .compatible = "qcom,x1e80100-ufshc", .data = &ufs_qcom_sm8550_drvdata }, Same problem here. Best regards, Krzysztof