On Tue, Aug 12, 2025 at 02:25:12PM +0530, Taniya Das wrote: > > > On 8/12/2025 9:15 AM, Bjorn Andersson wrote: > > On Wed, Jul 02, 2025 at 02:43:10PM +0530, Taniya Das wrote: > >> Add support for video, camera, display and gpu clock controller nodes > >> for QCS615 platform. > >> > >> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> > >> Signed-off-by: Taniya Das <quic_tdas@xxxxxxxxxxx> > >> --- > > > > DTC [C] arch/arm64/boot/dts/qcom/qcs615-ride.dtb > > /home/bjorn/sandbox/kernel/db845c/arch/arm64/boot/dts/qcom/qcs615-ride.dtb: clock-controller@100000: 'clock-names' is a required property > > from schema $id: http://devicetree.org/schemas/clock/qcom,qcs615-gcc.yaml# > > /home/bjorn/sandbox/kernel/db845c/arch/arm64/boot/dts/qcom/qcs615-ride.dtb: clock-controller@5090000: clocks: [[43, 0], [45, 2]] is too short > > from schema $id: http://devicetree.org/schemas/clock/qcom,qcs615-gpucc.yaml# > > /home/bjorn/sandbox/kernel/db845c/arch/arm64/boot/dts/qcom/qcs615-ride.dtb: clock-controller@5090000: Unevaluated properties are not allowed ('clocks' was unexpected) > > from schema $id: http://devicetree.org/schemas/clock/qcom,qcs615-gpucc.yaml# > > /home/bjorn/sandbox/kernel/db845c/arch/arm64/boot/dts/qcom/qcs615-ride.dtb: clock-controller@af00000: clocks: [[43, 0], [45, 29]] is too short > > from schema $id: http://devicetree.org/schemas/clock/qcom,qcs615-dispcc.yaml# > > /home/bjorn/sandbox/kernel/db845c/arch/arm64/boot/dts/qcom/qcs615-ride.dtb: clock-controller@af00000: Unevaluated properties are not allowed ('clocks' was unexpected) > > from schema $id: http://devicetree.org/schemas/clock/qcom,qcs615-dispcc.yaml# > > > > > > The missing clock-names in clock-controller@100000 predates this series. > > Sorry for merging broken patches in the past, please fix that as well. > > > > Bjorn, would you prefer that I add the clock-names property to the GCC > clock node to resolve the warning, or should I instead remove the > required: clock-names entry from the qcom,qcs615-gcc.yaml schema? > It seems to me that the qcs615 gcc binding and driver is lacking a number of clock inputs. Can you please look into correcting this, and based on that resolve the dtbs_check error? Thanks, Bjorn > Let me know which approach aligns better with your expectations. > > -- > Thanks, > Taniya Das >
