On Mon, Aug 11, 2025 at 10:24:29PM +0530, Ram Kumar Dwivedi wrote: > > > On 11-Aug-25 8:13 PM, Krzysztof Kozlowski wrote: > > On 11/08/2025 16:31, Ram Kumar Dwivedi wrote: > >> Enable Multi-Circular Queue (MCQ) support for the UFS host controller > >> on the Qualcomm SM8650 platform by updating the device tree node. This > >> includes adding new register region for MCQ and specifying the MSI parent > >> required for MCQ operation. > >> > >> Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@xxxxxxxxxxx> > >> --- > >> arch/arm64/boot/dts/qcom/sm8650.dtsi | 7 ++++++- > >> 1 file changed, 6 insertions(+), 1 deletion(-) > > > > Way you organize your patchset is confusing. Why DTS is in the middle? > > It suggests dependency and this would be strong objection from me. > > Hi Krzysztof, > > My current patch submission order is as follows: > > 1.DT binding > 2.Device tree > 3.Driver changes > > Please let me know if you'd prefer to rearrange the order and place the driver patch in the middle. THe recommended way is opposite: - DT bindings - Driver changes - DT changes This lets maintainers to pick up their parts with less troubles. > > > Regards, > Ram > > > > Please read carefully writing bindings, submitting patches in DT and SoC > > maintainer profile. > > > > Best regards, > > Krzysztof > -- With best wishes Dmitry