On 11/08/2025 17:02, Bjorn Andersson wrote: > On Mon, Aug 11, 2025 at 08:01:36PM +0530, Ram Kumar Dwivedi wrote: >> Document Multi-Circular Queue (MCQ) register space for >> Qualcomm UFS controllers. >> >> Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@xxxxxxxxxxx> >> --- >> .../devicetree/bindings/ufs/qcom,ufs.yaml | 16 ++++++++++------ >> 1 file changed, 10 insertions(+), 6 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> index 6c6043d9809e..daf681b0e23b 100644 >> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> @@ -89,9 +89,13 @@ properties: >> maxItems: 2 >> >> reg-names: >> - items: >> - - const: std >> - - const: ice >> + oneOf: >> + - items: >> + - const: std >> + - const: ice >> + - items: >> + - const: ufs_mem >> + - const: mcq > > So you can either "std" and "ice", or "ufs_mem" and "mcq". > > Does this imply that "std" changes name to "ufs_mem"? Why? > Is MCQ incompatible with ICE? I commented on v1 what has to be fixed. I also said I will provide the actual fix and then this is sent ignoring my comments and ignoring my fix. So no, this does not get fixed. NAK. Best regards, Krzysztof
