Re: [PATCH v8 2/7] media: venus: Define minimum valid firmware version

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/08/25 09:29:55, Bryan O'Donoghue wrote:
> On 05/08/2025 07:44, Jorge Ramirez-Ortiz wrote:
> > +	if (!is_fw_rev_or_newer(core, ver->major, ver->minor, ver->rev))
> > +		return -EINVAL;
> > +
> 
> This is the sort of error case that deserves a kernel log.
> 
> dev_err(dev, "Firmware version %d.%d < minimum version %d.%d\n, etc);
> 
> If I were to try booting venus with an old/unsupported I wouldn't know why
> the probe was failing.

ok

> 
> ---
> bod




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux