On Thu, Jul 24, 2025 at 03:40:52PM +0800, Yongxing Mou wrote: > > > On 2025/7/23 19:21, Dmitry Baryshkov wrote: > > On Wed, Jul 23, 2025 at 02:14:55PM +0800, Yongxing Mou wrote: > > > Enable DisplayPort support on all three USB-C ports of the > > > hamoa-iot-evk platform. > > > > > > Unlike most X1E-based boards, this platform uses FSUSB42 USB > > > switches for the USB0 Type-C port, while USB1 and USB2 rely on > > > Parade PS8830 retimers for Alt Mode switching. > > > > > > Support for the PS8830 retimers was already included in the > > > initial DTS, so this change adds support for the FSUSB42 switches. > > > > > > Due to limitations in the USB/DP combo PHY driver, DisplayPort > > > functionality is limited to 2 lanes instead of the maximum 4, > > > consistent with other X1E-based platforms. > > > > > > The platform also supports embedded DisplayPort (eDP) by default. > > > > > > Signed-off-by: Yongxing Mou <quic_yongmou@xxxxxxxxxxx> > > > --- > > > This change made top of initial DTS: > > > https://lore.kernel.org/all/20250716-hamoa_initial-v1-0-f6f5d0f9a163@xxxxxxxxxxxxxxxx/ > > > --- > > > arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 156 +++++++++++++++++++++++++++++ > > > 1 file changed, 156 insertions(+) > > > + > > > + ports { > > > + port@1 { > > > + reg = <1>; > > > + mdss_dp3_out: endpoint { > > > > Add empty endpoint to x1e80100.dtsi, then patch it here like you do for > > all other DP endpoints. > > > Hi So i need to add mdss_dp3_out: endpoint {} in x1e80100.dtsi and > +&mdss_dp3_out { > + data-lanes = <0 1 2 3>; > ... > in board dts.. is this understanding correct? > > i just wondering that here can we just follow other x1e80100-based dts? > others 8 x1e80100-based board dts all introduce edp-panel in this way.. I've sent a fix for that. While squashing this patchset, please update it accordingly. > > > + data-lanes = <0 1 2 3>; > > > + link-frequencies = /bits/ 64 <1620000000 2700000000 > > > + 5400000000 8100000000>; > > > + > > > + remote-endpoint = <&edp_panel_in>; > > > + }; > > > + }; > > > + }; > > > +}; > > > + > > > -- With best wishes Dmitry