Re: [PATCH 1/1] man2/mount.2: expand and clarify docs for MS_REMOUNT | MS_BIND

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 ---- On Fri, 22 Aug 2025 17:06:00 +0400  Aleksa Sarai <cyphar@xxxxxxxxxx> wrote --- 
 > > +The
 > > +.I mountflags
 > > +should specify existing per-mount-point flags,
 > > +except for those parameters
 > > +that are deliberately changed.
 > 
 > I would phrase this more like a note to make the advice a bit clearer:

I merely copied here text used for normal remounting (i. e. MS_REMOUNT without MS_BIND).
But okay, I changed anyway.

 >   (which can be retrieved using
 >   .BR statfs (2)),

I don't like reference to statfs here.

statfs returns both superblock and per-mount
flags. And you cannot know which is which. See
https://elixir.bootlin.com/linux/v6.17-rc2/source/fs/statfs.c#L51
.

So, I removed statfs reference and kept everything else.

 > The current docs only mention locked mounts once and the description is
 > kind of insufficient (it implies that only MS_REMOUNT affects this, and

I don't know how locked mounts work. So, if you have something to
add, then you can send separate patch.

I addressed all your points except for mentioned above.
--
Askar Safin
https://types.pl/@safinaskar





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux