On Fri, Aug 15, 2025 at 01:28:02PM +0800, Baolu Lu wrote: > On 8/12/25 06:59, Nicolin Chen wrote: > Given that iommu_group->mutex is transparent to the iommu driver, how > about > > /* > * Called only by iommu drivers in the callback context where > * group->mutex has already been held by the core. > */ > struct iommu_domain *iommu_get_domain_for_dev_internal(struct device *dev) > { > ... > lockdep_assert_held(&group->mutex); > ... > } I thought about the "_internal" tag, but didn't pick that because we seem to use that for an internal function inside iommu.c? I don't have a problem using that though, as it can be noted like like your writing. Thanks Nicolin