RE: [PATCH] ACPI: APEI: EINJ: fix potential NULL dereference in __einj_error_inject

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Charles Han <hanchunchao@xxxxxxxxxx>, "rafael@xxxxxxxxxx" <rafael@xxxxxxxxxx>, "bp@xxxxxxxxx" <bp@xxxxxxxxx>, "guohanjun@xxxxxxxxxx" <guohanjun@xxxxxxxxxx>, "mchehab@xxxxxxxxxx" <mchehab@xxxxxxxxxx>, "xueshuai@xxxxxxxxxxxxxxxxx" <xueshuai@xxxxxxxxxxxxxxxxx>, "lenb@xxxxxxxxxx" <lenb@xxxxxxxxxx>, "Weiny, Ira" <ira.weiny@xxxxxxxxx>, "zaidal@xxxxxxxxxxxxxxxxxxxxxx" <zaidal@xxxxxxxxxxxxxxxxxxxxxx>, "Jonathan.Cameron@xxxxxxxxxx" <Jonathan.Cameron@xxxxxxxxxx>, "colin.i.king@xxxxxxxxx" <colin.i.king@xxxxxxxxx>, "dan.carpenter@xxxxxxxxxx" <dan.carpenter@xxxxxxxxxx>, "Williams, Dan J" <dan.j.williams@xxxxxxxxx>, "sudeep.holla@xxxxxxx" <sudeep.holla@xxxxxxx>
Subject: RE: [PATCH] ACPI: APEI: EINJ: fix potential NULL dereference in __einj_error_inject
From: "Luck, Tony" <tony.luck@xxxxxxxxx>
Date: Fri, 15 Aug 2025 15:51:46 +0000
Accept-language: en-US
Cc: "linux-acpi@xxxxxxxxxxxxxxx" <linux-acpi@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <20250815024207.3038-1-hanchunchao@inspur.com>
References: <20250815024207.3038-1-hanchunchao@inspur.com>

> The __einj_error_inject() function allocates memory via kmalloc()
> without checking for allocation failure, which could lead to a
> NULL pointer dereference.
>
> Return -ENOMEM in case allocation fails.
>
> Fixes: b47610296d17 ("ACPI: APEI: EINJ: Enable EINJv2 error injections")
> Signed-off-by: Charles Han <hanchunchao@xxxxxxxxxx>

Reviewed-by: Tony Luck <tony.luck@xxxxxxxxx>

-Tony

References:
- [PATCH] ACPI: APEI: EINJ: fix potential NULL dereference in __einj_error_inject
  - From: Charles Han

Prev by Date: Re: [PATCH v3 1/5] iommu: Lock group->mutex in iommu_deferred_attach
Next by Date: Re: [PATCH v3 1/5] iommu: Lock group->mutex in iommu_deferred_attach
Previous by thread: Re: [PATCH] ACPI: APEI: EINJ: fix potential NULL dereference in __einj_error_inject
Next by thread: [PATCH] ACPI: PRM: Optimize the judgment logic for the PRM handler_address
Index(es):
- Date
- Thread

[Index of Archives] [Linux IBM ACPI] [Linux Power Management] [Linux Kernel] [Linux Laptop] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]