On Fri, Aug 22, 2025 at 09:55:33PM +0200, Markus Elfring wrote:
> …
> …
> > +static int mpam_msc_drv_probe(struct platform_device *pdev)
> > +{
> …
> > + } while (0);
> > + mutex_unlock(&mpam_list_lock);
> > +
> > + if (!err) {
> > + /* Create RIS entries described by firmware */
> > + if (!acpi_disabled)
> > + err = acpi_mpam_parse_resources(msc, plat_data);
> > + else
> > + err = mpam_dt_parse_resources(msc, plat_data);
> > + }
> > +
> > + if (!err && fw_num_msc == mpam_num_msc)
> > + mpam_discovery_complete();
> > +
> > + if (err && msc)
> > + mpam_msc_drv_remove(pdev);
> > +
> > + return err;
> > +}
> …
>
> * Would you like to integrate anything from the following source code variant?
>
> if (!err)
> /* Create RIS entries described by firmware */
> err = acpi_disabled
> ? mpam_dt_parse_resources(msc, plat_data)
> : acpi_mpam_parse_resources(msc, plat_data);
>
> if (err) {
> if (msc)
> mpam_msc_drv_remove(pdev);
> } else {
> if (fw_num_msc == mpam_num_msc)
> mpam_discovery_complete();
> }
>
> * How do you think about to increase the application of scope-based resource management
> at further places?
>
>
> Regards,
> Markus
Hi,
This is the semi-friendly patch-bot of Greg Kroah-Hartman.
Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list. I strongly suggest that you not do this anymore. Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.
Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all. The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback. Please feel free to also ignore emails
from them.
thanks,
greg k-h's patch email bot
