On Fri, Aug 29, 2025 at 07:34:17AM -0400, Jean-François Lessard wrote:
> Le 29 août 2025 00 h 23 min 22 s HAE, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> a écrit :
> >On Thu, Aug 28, 2025 at 10:17:59PM -0400, Jean-François Lessard wrote:
...
> >We need a real user of this before we can add them, so please do that as
> >part of a patch series.
> >
>
> I understand the "no dead code" policy, but I found existing manual
> implementations of this exact pattern in the current kernel.
>
> For example, drivers/i2c/i2c-core-slave.c already does:
>
> struct fwnode_handle *child __free(fwnode_handle) = NULL;
> ...
> fwnode_for_each_child_node(fwnode, child) {
> ...
> }
>
> This suggests developers are already wanting this functionality but
> implementing it manually.
>
> If included with my driver series, I would only add the
> fwnode_for_each_available_child_node_scoped() variant that I actually use,
I fully agree with Greg, please make it series out of two, I will review both
as soon as it appears in my mailbox.
--
With Best Regards,
Andy Shevchenko
