On Fri, Sep 5, 2025 at 10:19 AM Huisong Li <lihuisong@xxxxxxxxxx> wrote:
>
> If CONFIG_ACPI_PROCESSOR=n and CONFIG_ACPI_PROCESSOR_IDLE=n, we may encounter
> some warnings about function defined but not used.
> All external functions of processor_idle.c are just used in processor_driver.c.
> And if CONFIG_ACPI_PROCESSOR is selected and CONFIG_ACPI_PROCESSOR_IDLE also
> be selected automatically. So remove these empty function definitions.
>
> Signed-off-by: Huisong Li <lihuisong@xxxxxxxxxx>
> ---
> include/acpi/processor.h | 22 +---------------------
> 1 file changed, 1 insertion(+), 21 deletions(-)
>
> diff --git a/include/acpi/processor.h b/include/acpi/processor.h
> index ff864c1cee3a..d6a87dc42a9a 100644
> --- a/include/acpi/processor.h
> +++ b/include/acpi/processor.h
> @@ -417,34 +417,14 @@ static inline void acpi_processor_throttling_init(void) {}
> #endif /* CONFIG_ACPI_CPU_FREQ_PSS */
>
> /* in processor_idle.c */
> -extern struct cpuidle_driver acpi_idle_driver;
> #ifdef CONFIG_ACPI_PROCESSOR_IDLE
> +extern struct cpuidle_driver acpi_idle_driver;
The changes above don't belong to this patch IMV or at least I don't
see why they belong to it.
> int acpi_processor_power_init(struct acpi_processor *pr);
> int acpi_processor_power_exit(struct acpi_processor *pr);
> int acpi_processor_power_state_has_changed(struct acpi_processor *pr);
> int acpi_processor_hotplug(struct acpi_processor *pr);
> void acpi_processor_register_idle_driver(void);
> void acpi_processor_unregister_idle_driver(void);
> -#else
> -static inline int acpi_processor_power_init(struct acpi_processor *pr)
> -{
> - return -ENODEV;
> -}
> -
> -static inline int acpi_processor_power_exit(struct acpi_processor *pr)
> -{
> - return -ENODEV;
> -}
> -
> -static inline int acpi_processor_power_state_has_changed(struct acpi_processor *pr)
> -{
> - return -ENODEV;
> -}
> -
> -static inline int acpi_processor_hotplug(struct acpi_processor *pr)
> -{
> - return -ENODEV;
> -}
> #endif /* CONFIG_ACPI_PROCESSOR_IDLE */
>
> /* in processor_thermal.c */
> --
