Hi Ben, On 29/08/2025 09:42, Ben Horgan wrote: > On 8/22/25 16:29, James Morse wrote: >> Memory Partitioning and Monitoring (MPAM) has memory mapped devices >> (MSCs) with an identity/configuration page. >> >> Add the definitions for these registers as offset within the page(s). >> diff --git a/drivers/resctrl/mpam_internal.h b/drivers/resctrl/mpam_internal.h >> index d49bb884b433..6e0982a1a9ac 100644 >> --- a/drivers/resctrl/mpam_internal.h >> +++ b/drivers/resctrl/mpam_internal.h >> @@ -150,4 +150,270 @@ extern struct list_head mpam_classes; >> +/* MPAMF_PARTID_NRW_IDR - MPAM PARTID narrowing ID register */ >> +#define MPAMF_PARTID_NRW_IDR_INTPARTID_MAX GENMASK(15, 0) > > nit: spaces used instead of tabs Fixed, ~ > The names and values match the specification. > > Reviewed-by: Ben Horgan <ben.horgan@xxxxxxx> Thanks! James
