Re: [PATCH 07/33] arm64: kconfig: Add Kconfig entry for MPAM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, Sep 04, 2025 at 06:28:14PM +0100, James Morse wrote:
> Hi Dave,
> 
> On 27/08/2025 12:01, Dave Martin wrote:
> > <super-pedantic mode enabled>
> 
> Uh oh!
> 
> > (Since this likely be people's go-to patch for understanding what MPAM
> > is, it is probably worth going the extra mile.)
> > 
> > On Fri, Aug 22, 2025 at 03:29:48PM +0000, James Morse wrote:
> >> The bulk of the MPAM driver lives outside the arch code because it
> >> largely manages MMIO devices that generate interrupts. The driver
> >> needs a Kconfig symbol to enable it, as MPAM is only found on arm64
> > 
> > Prefer -> "[...] to enable it. As MPAM is only [...]"
> > 
> >> platforms, that is where the Kconfig option makes the most sense.
> > 
> > It could be clearer what "where" refers to, here.
> 
> Sure,
> 
> 
> > Maybe reword from ", that is [...]" -> ", the arm64 tree is the most
> > natural home for the Kconfig option."
> > 
> > (Or something like that.)
> 
> Sure,

[... etc., etc. ...]

> >> +	  partition-id and performance-monitoring-group to measure the
> >> +	  cache occupancy or data throughput.
> > 
> > So, how about something like:
> > 
> > --8<--
> > 
> > 	  Memory system components, such as the caches, can be configured with
> > 	  policies to control how much of various physical resources (such as
> > 	  memory bandwidth or cache memory) the transactions labelled with each
> > 	  PARTID can consume.  Depending on the capabilities of the hardware,
> > 	  the PARTID and PMG can also be used as filtering criteria to measure
> > 	  the memory system resource consumption of different parts of a
> > 	  workload.
> > 
> > -->8--
> 
> Done,
> 
> 
> > (Where "Memory system components" is used in a generic sense and so not
> > capitalised.)
> 
> (I can't wait for the Memory System Component on the Memory Side Cache!)

Urk.

MSC² ?

[...]

Cheers
---Dave




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]
  Powered by Linux