Hi Ben, On 28/08/2025 17:13, Ben Horgan wrote: > On 8/22/25 16:30, James Morse wrote: >> Resetting RIS entries from the cpuhp callback is easy as the >> callback occurs on the correct CPU. This won't be true for any other >> caller that wants to reset or configure an MSC. >> >> Add a helper that schedules the provided function if necessary. >> Prevent the cpuhp callbacks from changing the MSC state by taking the >> cpuhp lock. > At first, I thought this was referring to something done in the patch. > Consider changing to something like: > > Callers should take the cpuhp lock to prevent the cpuhp callbacks from > changing the MSC state. Yes - that is better, > Regardless, this looks good to me. > > Reviewed-by: Ben Horgan <ben.horgan@xxxxxxx> Thanks! James
