>-----Original Message-----
>From: Yazen Ghannam <yazen.ghannam@xxxxxxx>
>Sent: 09 September 2025 17:25
>To: Shiju Jose <shiju.jose@xxxxxxxxxx>
>Cc: rafael@xxxxxxxxxx; bp@xxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx;
>rppt@xxxxxxxxxx; dferguson@xxxxxxxxxxxxxxxxxxx; linux-
>edac@xxxxxxxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx; linux-mm@xxxxxxxxx; linux-
>doc@xxxxxxxxxxxxxxx; tony.luck@xxxxxxxxx; lenb@xxxxxxxxxx;
>leo.duran@xxxxxxx; mchehab@xxxxxxxxxx; Jonathan Cameron
><jonathan.cameron@xxxxxxxxxx>; Linuxarm <linuxarm@xxxxxxxxxx>;
>rientjes@xxxxxxxxxx; jiaqiyan@xxxxxxxxxx; Jon.Grimm@xxxxxxx;
>dave.hansen@xxxxxxxxxxxxxxx; naoya.horiguchi@xxxxxxx;
>james.morse@xxxxxxx; jthoughton@xxxxxxxxxx; somasundaram.a@xxxxxxx;
>erdemaktas@xxxxxxxxxx; pgonda@xxxxxxxxxx; duenwen@xxxxxxxxxx;
>gthelen@xxxxxxxxxx; wschwartz@xxxxxxxxxxxxxxxxxxx;
>wbs@xxxxxxxxxxxxxxxxxxxxxx; nifan.cxl@xxxxxxxxx; tanxiaofei
><tanxiaofei@xxxxxxxxxx>; Zengtao (B) <prime.zeng@xxxxxxxxxxxxx>; Roberto
>Sassu <roberto.sassu@xxxxxxxxxx>; kangkang.shen@xxxxxxxxxxxxx;
>wanghuiqiang <wanghuiqiang@xxxxxxxxxx>
>Subject: Re: [PATCH v12 1/2] ACPI:RAS2: Add ACPI RAS2 driver
>
>On Tue, Sep 02, 2025 at 06:30:39PM +0100, shiju.jose@xxxxxxxxxx wrote:
>> From: Shiju Jose <shiju.jose@xxxxxxxxxx>
>
>[...]
>
>> +static int ras2_add_aux_device(char *name, int channel, u32 pxm_inst)
>> +{
>> + unsigned long start_pfn, size_pfn;
>> + struct ras2_mem_ctx *ras2_ctx;
>> + int id, rc;
>
>'rc' is uninitialized, and LLVM gives a warning.
>
>The issue is the "goto ctx_free" paths return 'rc' before it is set.
Thanks Yazen. I missed setting rc with the error code in the failure case of the
newly added code. I will fix in the next version.
>
>> +
>> + ras2_ctx = kzalloc(sizeof(*ras2_ctx), GFP_KERNEL);
>> + if (!ras2_ctx)
>> + return -ENOMEM;
>> +
>> + ras2_ctx->sys_comp_nid = pxm_to_node(pxm_inst);
>> + /*
>> + * Retrieve the lowest contiguous physical memory address range within
>> + * the NUMA node.
>> + */
>> + start_pfn = node_start_pfn(ras2_ctx->sys_comp_nid);
>> + size_pfn = node_spanned_pages(ras2_ctx->sys_comp_nid);
>> + if (!size_pfn) {
>> + pr_debug("Failed to find phy addr range for NUMA node(%u)\n",
>> + pxm_inst);
>> + goto ctx_free;
>> + }
>> + ras2_ctx->mem_base_addr = __pfn_to_phys(start_pfn);
>> + ras2_ctx->mem_size = __pfn_to_phys(size_pfn);
>> +
[...]
>
>Thanks,
>Yazen
Thanks,
Shiju
