Re: [PATCH v6 01/15] x86/mce: Set CR4.MCE last during init

[Nikolay Borisov <nik.borisov@xxxxxxxx>]

On 9/8/25 18:40, Yazen Ghannam wrote:
> Set the CR4.MCE bit as the last step during init. This brings the MCA
> init flow closer to what is described in the x86 docs.
>
> x86 docs:
> 	AMD		Intel
> 			MCG_CTL
> 	MCA_CONFIG	MCG_EXT_CTL
> 	MCi_CTL		MCi_CTL
> 	MCG_CTL
> 	CR4.MCE		CR4.MCE
>
> Current Linux:
> 	AMD		Intel
> 	CR4.MCE		CR4.MCE
> 	MCG_CTL		MCG_CTL
> 	MCA_CONFIG	MCG_EXT_CTL
> 	MCi_CTL		MCi_CTL
>
> Updated Linux:
> 	AMD		Intel
> 	MCG_CTL		MCG_CTL
> 	MCA_CONFIG	MCG_EXT_CTL
> 	MCi_CTL		MCi_CTL
> 	CR4.MCE		CR4.MCE
>
> The new init flow will match Intel's docs, but there will still be a
> mismatch for AMD regarding MCG_CTL. However, there is no known issue
> with this ordering, so leave it for now.
>
> Signed-off-by: Yazen Ghannam <yazen.ghannam@xxxxxxx> 

Reviewed-by: Nikolay Borisov <nik.borisov@xxxxxxxx>