… > +++ b/drivers/resctrl/mpam_internal.h > @@ -152,4 +152,271 @@ extern struct list_head mpam_classes; … > +/* Error conditions in accessing memory mapped registers */ > +#define MPAM_ERRCODE_NONE 0 > +#define MPAM_ERRCODE_PARTID_SEL_RANGE 1 … > +#define MPAM_ERRCODE_UNEXPECTED_INTERNAL 7 … How do you think about to use an enumeration for such a value collection? (Is there a need to extend implementation details in similar ways at further source code places?) Regards, Markus