On Fri, Sep 12, 2025 at 12:04:57PM +0000, Shiju Jose wrote: > >Why is this requirement here? > The physical memory address range retrieved here for the NUMA domain is used in the subsequent > patch [PATCH v12 2/2] ras: mem: Add memory ACPI RAS2 driver, > 1. to set Requested Address Range(INPUT) field of Table 5.87: Parameter Block Structure for PATROL_SCRUB > when send GET_PATROL_PARAMETERS command to the firmware, to get scrub parameters, running status, > current scrub rate etc. > 2. for the validity check of the user requested memory address range to scrub. Again, why does it have to be *lowest* and *contiguous*? Your answer doesn't explain that. > Also intended to expose this supported memory address range to the > userspace via EDAC scrub control interface, though it is not present now. Why? To tie ourselves with even more user ABI?! There better be a good reason and not a better design for what this is trying to do. > >What happens with the aux devices you created successfully here? Unwind? > Please see the previous discussions on this were about allowing the successfully created > auxiliary devices to exist. > https://lore.kernel.org/all/20250415210504.GA854098@xxxxxxxxxxxxxxxxx/ There's no discussion here. And nothing answers the question "why" this is ok to do this way. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
