Re: [PATCH v4 1/3] rust: device_id: split out index support into a separate trait

[Danilo Krummrich <dakr@xxxxxxxxxx>]

On 7/11/25 6:09 AM, FUJITA Tomonori wrote:
> diff --git a/rust/kernel/driver.rs b/rust/kernel/driver.rs
> index f8dd7593e8dc..a8f2675ba7a7 100644
> --- a/rust/kernel/driver.rs
> +++ b/rust/kernel/driver.rs
> @@ -170,7 +170,7 @@ fn acpi_id_info(dev: &device::Device) -> Option<&'static Self::IdInfo> {
>                   // and does not add additional invariants, so it's safe to transmute.
>                   let id = unsafe { &*raw_id.cast::<acpi::DeviceId>() };
>   
> -                Some(table.info(<acpi::DeviceId as crate::device_id::RawDeviceId>::index(id)))
> +                Some(table.info(<acpi::DeviceId as crate::device_id::RawDeviceIdIndex>::index(id)))
>               }
>           }
>       }
> @@ -204,7 +204,11 @@ fn of_id_info(dev: &device::Device) -> Option<&'static Self::IdInfo> {
>                   // and does not add additional invariants, so it's safe to transmute.
>                   let id = unsafe { &*raw_id.cast::<of::DeviceId>() };
>   
> -                Some(table.info(<of::DeviceId as crate::device_id::RawDeviceId>::index(id)))
> +                Some(
> +                    table.info(<of::DeviceId as crate::device_id::RawDeviceIdIndex>::index(
> +                        id,
> +                    )),
> +                )

Just in case someone wonders why this is weirdly formatted, while the acpi one
above is a single line, this seems to be a bug in rustfmt.

>               }
>           }
>       }