Hi Ricardo,
A few more comments.
On Thu, Jun 05, 2025 at 05:52:56PM +0000, Ricardo Ribalda wrote:
> The function v4l2_fwnode_device_parse() is not capable of parsint the
s/not/now/
s/parsin\Kt/g/
?
> _PLD method, there is no need to duplicate the rotation information in a
> swnode.
>
> Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
> ---
> drivers/acpi/mipi-disco-img.c | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/drivers/acpi/mipi-disco-img.c b/drivers/acpi/mipi-disco-img.c
> index 5b85989f96beeb726f59ac9e12e965a215fb38f6..b58b5ba22a47a4afc5212998074d322f0b7586dc 100644
> --- a/drivers/acpi/mipi-disco-img.c
> +++ b/drivers/acpi/mipi-disco-img.c
> @@ -617,21 +617,6 @@ static void init_crs_csi2_swnodes(struct crs_csi2 *csi2)
>
> adev_fwnode = acpi_fwnode_handle(adev);
>
> - /*
> - * If the "rotation" property is not present, but _PLD is there,
> - * evaluate it to get the "rotation" value.
> - */
> - if (!fwnode_property_present(adev_fwnode, "rotation")) {
> - struct acpi_pld_info *pld;
> -
> - if (acpi_get_physical_device_location(handle, &pld)) {
> - swnodes->dev_props[NEXT_PROPERTY(prop_index, DEV_ROTATION)] =
> - PROPERTY_ENTRY_U32("rotation",
> - pld->rotation * 45U);
> - kfree(pld);
> - }
> - }
> -
> if (!fwnode_property_read_u32(adev_fwnode, "mipi-img-clock-frequency", &val))
> swnodes->dev_props[NEXT_PROPERTY(prop_index, DEV_CLOCK_FREQUENCY)] =
> PROPERTY_ENTRY_U32("clock-frequency", val);
>
--
Regards,
Sakari Ailus
