On Wed, Jul 2, 2025 at 6:38 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Wed, Jul 02, 2025 at 10:43:31AM +0530, Anup Patel wrote: > > > > The RPMI specification defines a clock service group which can be > > accessed via SBI MPXY extension or dedicated S-mode RPMI transport. > > > > Add mailbox client based clock driver for the RISC-V RPMI clock > > service group. > > Now it looks much better! > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > One nit-pick below. > > ... > > > +/* > > + * rpmi_clk_rates represents the rates format > > + * as specified by the RPMI specification. > > + * No other format conversion(eg. linear_range) is > > + * required to avoid to and fro conversion. > > conversion appears twice. I would suggest use this: > > * No other data format (e.g., struct linear_range) is > * required to avoid to and from conversion. > I will update it in the next revision. Thanks, Anup
